From: Hyihong Chae Date: Tue, 29 Mar 2016 08:27:04 +0000 (+0900) Subject: add code coverage comment. X-Git-Tag: submit/tizen/20160329.083404^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a48e8b9ed49c494443c9905535b5bee377238d97;p=platform%2Fcore%2Fapi%2Fmtp.git add code coverage comment. Change-Id: Id1ecd72edaf234409d7100768a8e6826b2375567 Signed-off-by: HyiHong Chae --- diff --git a/packaging/capi-network-mtp.spec b/packaging/capi-network-mtp.spec index 604aa9f..1e721a2 100755 --- a/packaging/capi-network-mtp.spec +++ b/packaging/capi-network-mtp.spec @@ -1,6 +1,6 @@ Name: capi-network-mtp Summary: A MTP library in Native API -Version: 1.3.11 +Version: 1.3.12 Release: 1 Group: Network & Connectivity/Other License: Apache-2.0 diff --git a/src/mtp.c b/src/mtp.c index 7d4109f..df9fcf9 100755 --- a/src/mtp.c +++ b/src/mtp.c @@ -118,6 +118,8 @@ int mtp_get_devices(int **mtp_devices, int *device_count) CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_devices == NULL, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(device_count == NULL, MTP_ERROR_INVALID_PARAMETER); /* precondition check end */ @@ -129,6 +131,7 @@ int mtp_get_devices(int **mtp_devices, int *device_count) _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_get_storages(int mtp_device, int **mtp_storages, int* storage_count) @@ -143,6 +146,8 @@ int mtp_get_storages(int mtp_device, int **mtp_storages, int* storage_count) CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_device == 0, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(mtp_storages == NULL, MTP_ERROR_INVALID_PARAMETER); cond_expr_ret(storage_count == NULL, MTP_ERROR_INVALID_PARAMETER); @@ -155,6 +160,7 @@ int mtp_get_storages(int mtp_device, int **mtp_storages, int* storage_count) _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_get_object_handles(int mtp_device, int mtp_storage, mtp_filetype_e file_type, @@ -170,6 +176,8 @@ int mtp_get_object_handles(int mtp_device, int mtp_storage, mtp_filetype_e file_ CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_device == 0, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(mtp_storage == 0, MTP_ERROR_INVALID_PARAMETER); cond_expr_ret(object_handles == NULL, MTP_ERROR_INVALID_PARAMETER); cond_expr_ret(object_count == NULL, MTP_ERROR_INVALID_PARAMETER); @@ -182,8 +190,10 @@ int mtp_get_object_handles(int mtp_device, int mtp_storage, mtp_filetype_e file_ _END(); return ret; + /* LCOV_EXCL_STOP */ } +/* LCOV_EXCL_START */ int mtp_delete_object(int mtp_device, int object_handle) { int ret = MTP_ERROR_NONE; @@ -206,6 +216,7 @@ int mtp_delete_object(int mtp_device, int object_handle) return ret; } +/* LCOV_EXCL_STOP */ int mtp_get_object(int mtp_device, int object_handle, char *dest_path) { @@ -219,6 +230,8 @@ int mtp_get_object(int mtp_device, int object_handle, char *dest_path) CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_device == 0, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(dest_path == NULL, MTP_ERROR_INVALID_PARAMETER); /* precondition check end */ @@ -228,6 +241,7 @@ int mtp_get_object(int mtp_device, int object_handle, char *dest_path) _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_get_thumbnail(int mtp_device, int object_handle, char *dest_path) @@ -242,6 +256,8 @@ int mtp_get_thumbnail(int mtp_device, int object_handle, char *dest_path) CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_device == 0, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(dest_path == NULL, MTP_ERROR_INVALID_PARAMETER); /* precondition check end */ @@ -251,6 +267,7 @@ int mtp_get_thumbnail(int mtp_device, int object_handle, char *dest_path) _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_add_mtp_event_cb(mtp_event_cb callback, void *user_data) @@ -342,6 +359,7 @@ int mtp_deviceinfo_get_manufacturer_name(int mtp_device, char **manufacturer_nam /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_deviceinfo_get_manufacturer_name(mtp_device, manufacturer_name); TC_PRT("manufacturername %s", *manufacturer_name); @@ -349,6 +367,7 @@ int mtp_deviceinfo_get_manufacturer_name(int mtp_device, char **manufacturer_nam _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_deviceinfo_get_model_name(int mtp_device, char **model_name) @@ -366,6 +385,7 @@ int mtp_deviceinfo_get_model_name(int mtp_device, char **model_name) /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_deviceinfo_get_model_name(mtp_device, model_name); TC_PRT("modelname %s", *model_name); @@ -373,6 +393,7 @@ int mtp_deviceinfo_get_model_name(int mtp_device, char **model_name) _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_deviceinfo_get_serial_number(int mtp_device, char **serial_number) @@ -390,6 +411,7 @@ int mtp_deviceinfo_get_serial_number(int mtp_device, char **serial_number) /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_deviceinfo_get_serial_number(mtp_device, serial_number); TC_PRT("serial number %s", *serial_number); @@ -397,6 +419,7 @@ int mtp_deviceinfo_get_serial_number(int mtp_device, char **serial_number) _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_deviceinfo_get_device_version(int mtp_device, char **device_version) @@ -414,6 +437,7 @@ int mtp_deviceinfo_get_device_version(int mtp_device, char **device_version) /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_deviceinfo_get_device_version(mtp_device, device_version); TC_PRT("device version %s", *device_version); @@ -421,8 +445,10 @@ int mtp_deviceinfo_get_device_version(int mtp_device, char **device_version) _END(); return ret; + /* LCOV_EXCL_STOP */ } +/* LCOV_EXCL_START */ int mtp_deviceinfo_get_bus_location(int mtp_device, int *bus_location) { int ret = MTP_ERROR_NONE; @@ -472,6 +498,7 @@ int mtp_deviceinfo_get_device_number(int mtp_device, int *device_number) return ret; } +/* LCOV_EXCL_STOP */ /* Storage Info */ int mtp_storageinfo_get_description(int mtp_device, int mtp_storage, char **description) @@ -486,6 +513,8 @@ int mtp_storageinfo_get_description(int mtp_device, int mtp_storage, char **desc CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_device == 0, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(mtp_storage == 0, MTP_ERROR_INVALID_PARAMETER); /* precondition check end */ @@ -497,6 +526,7 @@ int mtp_storageinfo_get_description(int mtp_device, int mtp_storage, char **desc _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_storageinfo_get_free_space(int mtp_device, int mtp_storage, unsigned long long *free_space) @@ -511,6 +541,8 @@ int mtp_storageinfo_get_free_space(int mtp_device, int mtp_storage, unsigned lon CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_device == 0, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(mtp_storage == 0, MTP_ERROR_INVALID_PARAMETER); /* precondition check end */ @@ -522,6 +554,7 @@ int mtp_storageinfo_get_free_space(int mtp_device, int mtp_storage, unsigned lon _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_storageinfo_get_max_capacity(int mtp_device, int mtp_storage, unsigned long long *max_capacity) @@ -536,6 +569,8 @@ int mtp_storageinfo_get_max_capacity(int mtp_device, int mtp_storage, unsigned l CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_device == 0, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(mtp_storage == 0, MTP_ERROR_INVALID_PARAMETER); /* precondition check end */ @@ -547,6 +582,7 @@ int mtp_storageinfo_get_max_capacity(int mtp_device, int mtp_storage, unsigned l _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_storageinfo_get_storage_type(int mtp_device, int mtp_storage, mtp_storage_type_e *storage_type) @@ -561,6 +597,8 @@ int mtp_storageinfo_get_storage_type(int mtp_device, int mtp_storage, mtp_storag CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_device == 0, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(mtp_storage == 0, MTP_ERROR_INVALID_PARAMETER); /* precondition check end */ @@ -572,6 +610,7 @@ int mtp_storageinfo_get_storage_type(int mtp_device, int mtp_storage, mtp_storag _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_storageinfo_get_volume_identifier(int mtp_device, int mtp_storage, char **volume_identifier) @@ -586,6 +625,8 @@ int mtp_storageinfo_get_volume_identifier(int mtp_device, int mtp_storage, char CHECK_INIT(); CHECK_ACTIVATED(); cond_expr_ret(mtp_device == 0, MTP_ERROR_INVALID_PARAMETER); + + /* LCOV_EXCL_START */ cond_expr_ret(mtp_storage == 0, MTP_ERROR_INVALID_PARAMETER); /* precondition check end */ @@ -597,6 +638,7 @@ int mtp_storageinfo_get_volume_identifier(int mtp_device, int mtp_storage, char _END(); return ret; + /* LCOV_EXCL_STOP */ } /* Object Info */ @@ -616,6 +658,7 @@ int mtp_objectinfo_get_parent_object_handle(int mtp_device, int object_handle, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_PARENT_OBJECT_HANDLE, parent_object_handle); @@ -624,6 +667,7 @@ int mtp_objectinfo_get_parent_object_handle(int mtp_device, int object_handle, _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_storage(int mtp_device, int object_handle, @@ -642,12 +686,14 @@ int mtp_objectinfo_get_storage(int mtp_device, int object_handle, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_STORAGE, mtp_storage); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_association_desc(int mtp_device, @@ -666,12 +712,14 @@ int mtp_objectinfo_get_association_desc(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_ASSOCIATION_DESC, asso_desc); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_association_type(int mtp_device, @@ -690,12 +738,14 @@ int mtp_objectinfo_get_association_type(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_ASSOCIATION_TYPE, asso_type); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_size(int mtp_device, int object_handle, int *size) @@ -713,12 +763,14 @@ int mtp_objectinfo_get_size(int mtp_device, int object_handle, int *size) /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_SIZE, size); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_date_created(int mtp_device, @@ -737,12 +789,14 @@ int mtp_objectinfo_get_date_created(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_DATE_CREATED, data_created); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_date_modified(int mtp_device, @@ -761,12 +815,14 @@ int mtp_objectinfo_get_date_modified(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_DATE_MODIFIED, data_modified); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_file_type(int mtp_device, int object_handle, mtp_filetype_e *file_type) @@ -784,12 +840,14 @@ int mtp_objectinfo_get_file_type(int mtp_device, int object_handle, mtp_filetype /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_FILE_TYPE, (int*)file_type); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_image_bit_depth(int mtp_device, @@ -808,12 +866,14 @@ int mtp_objectinfo_get_image_bit_depth(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_IMAGE_BIT_DEPTH, depth); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_image_pix_width(int mtp_device, @@ -832,12 +892,14 @@ int mtp_objectinfo_get_image_pix_width(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_IMAGE_PIX_WIDTH, width); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_image_pix_height(int mtp_device, @@ -856,12 +918,14 @@ int mtp_objectinfo_get_image_pix_height(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_IMAGE_PIX_HEIGHT, height); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_thumbnail_size(int mtp_device, @@ -880,12 +944,14 @@ int mtp_objectinfo_get_thumbnail_size(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_THUMBNAIL_SIZE, size); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_thumbnail_file_type(int mtp_device, @@ -904,12 +970,14 @@ int mtp_objectinfo_get_thumbnail_file_type(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_THUMBNAIL_FILE_TYPE, (int*)file_type); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_thumbnail_pix_height(int mtp_device, @@ -928,12 +996,14 @@ int mtp_objectinfo_get_thumbnail_pix_height(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_THUMBNAIL_HEIGHT, height); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_thumbnail_pix_width(int mtp_device, @@ -952,12 +1022,14 @@ int mtp_objectinfo_get_thumbnail_pix_width(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property(mtp_device, object_handle, MTP_PROPERTY_THUMBNAIL_WIDTH, width); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_file_name(int mtp_device, @@ -976,12 +1048,14 @@ int mtp_objectinfo_get_file_name(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property_string(mtp_device, object_handle, MTP_PROPERTY_FILENAME, filename); _END(); return ret; + /* LCOV_EXCL_STOP */ } int mtp_objectinfo_get_keywords(int mtp_device, @@ -1000,14 +1074,17 @@ int mtp_objectinfo_get_keywords(int mtp_device, /* precondition check end */ + /* LCOV_EXCL_START */ ret = mtp_gdbus_objectinfo_get_property_string(mtp_device, object_handle, MTP_PROPERTY_KEYWORDS, keywords); _END(); return ret; + /* LCOV_EXCL_STOP */ } +/* LCOV_EXCL_START */ int mtp_objectinfo_get_object_info(int mtp_device, int object_handle, mtp_object_info **object_info) { @@ -1030,4 +1107,5 @@ int mtp_objectinfo_get_object_info(int mtp_device, return ret; } +/* LCOV_EXCL_STOP */ diff --git a/src/mtp_db.c b/src/mtp_db.c index ddd1e2e..c70d8c3 100755 --- a/src/mtp_db.c +++ b/src/mtp_db.c @@ -49,6 +49,7 @@ mtp_error_e mtp_db_init() return ret; } +/* LCOV_EXCL_START */ mtp_error_e mtp_db_get_object_info(int mtp_device, int object_handle, mtp_object_info** object_info) { int ret = MTP_ERROR_NONE; @@ -112,6 +113,7 @@ mtp_error_e mtp_db_get_object_info(int mtp_device, int object_handle, mtp_object return ret; } +/* LCOV_EXCL_STOP */ mtp_error_e mtp_db_deinit() { @@ -124,7 +126,7 @@ mtp_error_e mtp_db_deinit() sql_ret = sqlite3_close(db); if (sql_ret != SQLITE_OK) - ret = MTP_ERROR_DB; + ret = MTP_ERROR_DB; /* LCOV_EXCL_LINE */ db = NULL; } diff --git a/src/mtp_gdbus_deviceinfo.c b/src/mtp_gdbus_deviceinfo.c index 8f16d56..a319dee 100755 --- a/src/mtp_gdbus_deviceinfo.c +++ b/src/mtp_gdbus_deviceinfo.c @@ -34,6 +34,7 @@ void mtp_gdbus_deviceinfo_proxy_deinit(void) deviceinfo_proxy = NULL; } +/* LCOV_EXCL_START */ mtp_error_e mtp_gdbus_deviceinfo_get_manufacturer_name(int mtp_device, char **manufacturer_name) { mtp_error_e result = MTP_ERROR_NONE; @@ -165,4 +166,5 @@ mtp_error_e mtp_gdbus_deviceinfo_get_device_number(int mtp_device, int *device_n return result; } +/* LCOV_EXCL_STOP */ diff --git a/src/mtp_gdbus_manager.c b/src/mtp_gdbus_manager.c index a34e654..f3869b8 100755 --- a/src/mtp_gdbus_manager.c +++ b/src/mtp_gdbus_manager.c @@ -33,6 +33,7 @@ typedef struct _event_cb_s { mtpgdbuslibManager *manager_proxy = NULL; static __thread GSList *event_cb_list = NULL; +/* LCOV_EXCL_START */ static void __mtp_event_cb(mtpgdbuslibManager *object, gint event, gint arg1, gpointer user_data) { @@ -44,6 +45,7 @@ static void __mtp_event_cb(mtpgdbuslibManager *object, event_s->cb(event, arg1, event_s->user_data); } } +/* LCOV_EXCL_STOP */ static void __manager_proxy_init(void) { @@ -87,9 +89,11 @@ mtp_error_e mtp_gdbus_manager_remove_event_cb(mtp_event_cb callback) event_cb_s *event_s; for (l = event_cb_list; l != NULL; l = l->next) { + /* LCOV_EXCL_START */ event_s = (event_cb_s *)l->data; if (callback == event_s->cb) event_cb_list = g_slist_delete_link(event_cb_list, l); + /* LCOV_EXCL_STOP */ } return MTP_ERROR_NONE; @@ -113,11 +117,12 @@ mtp_error_e mtp_gdbus_manager_initialize(void) mtp_gdbus_objectinfo_proxy_init(); if (manager_proxy == NULL) - result = MTP_ERROR_NOT_COMM_INITIALIZED; + result = MTP_ERROR_NOT_COMM_INITIALIZED; /* LCOV_EXCL_LINE */ return result; } +/* LCOV_EXCL_START */ mtp_error_e mtp_gdbus_manager_get_devices(int **mtp_devices, int *device_num) { GVariant *va = NULL; @@ -339,6 +344,7 @@ mtp_error_e mtp_gdbus_manager_get_thumbnail(int mtp_device, return result; } +/* LCOV_EXCL_STOP */ mtp_error_e mtp_gdbus_manager_deinitialize(void) { diff --git a/src/mtp_gdbus_objectinfo.c b/src/mtp_gdbus_objectinfo.c index c5382ff..de27bef 100755 --- a/src/mtp_gdbus_objectinfo.c +++ b/src/mtp_gdbus_objectinfo.c @@ -34,6 +34,7 @@ void mtp_gdbus_objectinfo_proxy_deinit(void) objectinfo_proxy = NULL; } +/* LCOV_EXCL_START */ int mtp_gdbus_objectinfo_get_property(int mtp_device, int object_handle, int property, int *property_value) { @@ -83,4 +84,5 @@ int mtp_gdbus_objectinfo_get_property_string(int mtp_device, return result; } +/* LCOV_EXCL_STOP */ diff --git a/src/mtp_gdbus_storageinfo.c b/src/mtp_gdbus_storageinfo.c index 2698bb2..29cf370 100755 --- a/src/mtp_gdbus_storageinfo.c +++ b/src/mtp_gdbus_storageinfo.c @@ -34,6 +34,7 @@ void mtp_gdbus_storageinfo_proxy_deinit(void) storageinfo_proxy = NULL; } +/* LCOV_EXCL_START */ mtp_error_e mtp_gdbus_storageinfo_get_description(int mtp_device, int mtp_storage, char **description) { @@ -153,3 +154,5 @@ mtp_error_e mtp_gdbus_storageinfo_get_volume_identifier(int mtp_device, return result; } +/* LCOV_EXCL_STOP */ +