From: Jan Schmidt <jan@centricular.com>
Date: Thu, 23 Nov 2017 12:01:52 +0000 (+1100)
Subject: viv-fb: Don't destroy the native FB display
X-Git-Tag: 1.19.3~511^2~1989^2~12
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a4834c43522a293c027e922aa8fe4a9e614c3000;p=platform%2Fupstream%2Fgstreamer.git

viv-fb: Don't destroy the native FB display

It causes crashes in applications because the result of
fbGetDisplay() might be in use elsewhere in the application
and Vivante doesn't seem to do any refcounting
---

diff --git a/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c b/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c
index 48815e5..b90273e 100644
--- a/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c
+++ b/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c
@@ -59,8 +59,8 @@ gst_gl_display_viv_fb_finalize (GObject * object)
 {
   GstGLDisplayVivFB *display_viv_fb = GST_GL_DISPLAY_VIV_FB (object);
 
-  if (display_viv_fb->display)
-    fbDestroyDisplay (display_viv_fb->display);
+  // We don't destroy the FB Display - it causes crashes in applications
+  // because Vivante doesn't seem to do any refcounting
 
   G_OBJECT_CLASS (gst_gl_display_viv_fb_parent_class)->finalize (object);
 }