From: Wei Yongjun Date: Fri, 15 Nov 2013 07:48:56 +0000 (+0800) Subject: spi: mpc512x: fix reference leak to master in mpc512x_psc_spi_do_remove() X-Git-Tag: v3.13-rc3~27^2^4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a4469a429fc71af6bad9c9e3f7307249dedfe8d1;p=platform%2Fkernel%2Flinux-exynos.git spi: mpc512x: fix reference leak to master in mpc512x_psc_spi_do_remove() Once a spi_master_get() call succeeds, we need an additional spi_master_put() call to free the memory, otherwise we will leak a reference to master. Fix by removing the unnecessary spi_master_get() call. Fixes: eaa24297846b ('spi: mpc512x: use devm_spi_register_master()') Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index ee6e61c..e9f22a8 100644 --- a/drivers/spi/spi-mpc512x-psc.c +++ b/drivers/spi/spi-mpc512x-psc.c @@ -556,7 +556,7 @@ free_master: static int mpc512x_psc_spi_do_remove(struct device *dev) { - struct spi_master *master = spi_master_get(dev_get_drvdata(dev)); + struct spi_master *master = dev_get_drvdata(dev); struct mpc512x_psc_spi *mps = spi_master_get_devdata(master); clk_disable_unprepare(mps->clk_mclk);