From: Peter Ujfalusi Date: Thu, 31 Mar 2022 11:47:57 +0000 (+0300) Subject: ASoC: SOF: ipc3-topology: Set scontrol->priv to NULL after freeing it X-Git-Tag: v6.6.17~6759^2~68^2~175 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a403993ce98fb401f696da7c4f374739a7609cff;p=platform%2Fkernel%2Flinux-rpi.git ASoC: SOF: ipc3-topology: Set scontrol->priv to NULL after freeing it Since the scontrol->priv is freed up during load operation it should be set to NULL to be safe against double freeing attempt. Fixes: b5cee8feb1d48 ("ASoC: SOF: topology: Make control parsing IPC agnostic") Signed-off-by: Peter Ujfalusi Reviewed-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20220331114757.32551-1-peter.ujfalusi@linux.intel.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c index 2f8450a..2e1c76e 100644 --- a/sound/soc/sof/ipc3-topology.c +++ b/sound/soc/sof/ipc3-topology.c @@ -1592,6 +1592,7 @@ static int sof_ipc3_control_load_bytes(struct snd_sof_dev *sdev, struct snd_sof_ if (scontrol->priv_size > 0) { memcpy(cdata->data, scontrol->priv, scontrol->priv_size); kfree(scontrol->priv); + scontrol->priv = NULL; if (cdata->data->magic != SOF_ABI_MAGIC) { dev_err(sdev->dev, "Wrong ABI magic 0x%08x.\n", cdata->data->magic);