From: Paul Lawrence <paullawrence@google.com>
Date: Wed, 11 Sep 2024 19:53:39 +0000 (-0700)
Subject: ANDROID: dm-bow: Fix empty else blocks
X-Git-Tag: accepted/tizen/unified/20250101.165744^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a401dcc72dd208d597dbe7434df3af7a2ef929f1;p=platform%2Fkernel%2Flinux-tizen-modules-source.git

ANDROID: dm-bow: Fix empty else blocks

drivers/md/dm-bow.c:1149:51: error: suggest braces around empty body
in an ‘else’ statement [-Werror=empty-body]
drivers/md/dm-bow.c:1142:51: error: suggest braces around empty body
in an ‘else’ statement [-Werror=empty-body]

Link to kernelci result:
https://linux.kernelci.org/build/android/branch/android-mainline/kernel/v6.11-rc6-6389-g1cf1608b4abd8/

Build log: https://storage.kernelci.org/android/android-mainline/v6.11-rc6-6389-g1cf1608b4abd8/x86_64/allmodconfig/gcc-12/logs/kernel.log

Bug: 366029436
Test: compiles
Signed-off-by: Paul Lawrence <paullawrence@google.com>
[jh80.chung: Taken from Android Common Kernel repo]
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>

Change-Id: Ib6ea01a36c0300aba512a743e658737afcc9ebfa
---

diff --git a/kernel/dm-bow.c b/kernel/dm-bow.c
index f8ccfad..3d577a3 100644
--- a/kernel/dm-bow.c
+++ b/kernel/dm-bow.c
@@ -1138,18 +1138,15 @@ static int dm_bow_map(struct dm_target *ti, struct bio *bio)
 				ret = add_trim(bc, bio);
 			else if (bio_data_dir(bio) == WRITE)
 				ret = remove_trim(bc, bio);
-			else
-				/* pass-through */;
+			/* else pass-through */
 		} else if (state == CHECKPOINT) {
 			if (bio->bi_iter.bi_sector == 0)
 				ret = handle_sector0(bc, bio);
 			else if (bio_data_dir(bio) == WRITE)
 				ret = queue_write(bc, bio);
-			else
-				/* pass-through */;
-		} else {
-			/* pass-through */
+			/* else pass-through */
 		}
+		/* else pass-through */
 		mutex_unlock(&bc->ranges_lock);
 	}