From: Reini Urban <rurban@x-ray.at>
Date: Tue, 22 Nov 2011 19:30:08 +0000 (-0600)
Subject: arybase.xs be more defensive
X-Git-Tag: accepted/trunk/20130322.191538~1995
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a3f353cf7aaf90ddfb021a9733ff75f4437d4e70;p=platform%2Fupstream%2Fperl.git

arybase.xs be more defensive

There can be no other keys used with ab_ck_base but clang's static
analyzer has a point in complaining about the missing default case.
This is too fragile if any CHECK is added in BOOT.
---

diff --git a/ext/arybase/arybase.xs b/ext/arybase/arybase.xs
index d654b54..861b322 100644
--- a/ext/arybase/arybase.xs
+++ b/ext/arybase/arybase.xs
@@ -343,6 +343,10 @@ static OP *ab_ck_base(pTHX_ OP *o)
  case OP_RINDEX   : old_ck = ab_old_ck_rindex   ; break;
  case OP_INDEX    : old_ck = ab_old_ck_index    ; break;
  case OP_POS      : old_ck = ab_old_ck_pos      ; break;
+ default:
+  DIE(aTHX_
+     "panic: invalid op type for arybase.xs:ab_ck_base: %d",
+      PL_op->op_type);
  }
  o = (*old_ck)(aTHX_ o);
  /* We need two switch blocks, as the type may have changed. */