From: Dmitry Torokhov Date: Thu, 28 May 2009 16:51:31 +0000 (-0700) Subject: Input: libps2 - better handle bad scheduler decisions X-Git-Tag: upstream/snapshot3+hdmi~18759^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a3ce6ea46cc0d6397d1b92b1a5983bb2935306ed;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git Input: libps2 - better handle bad scheduler decisions Sometimes devices send us their responses in time but due to unfortunate scheduling decisions the receiving thread does not get scheduled till much later and we erroneously decide that device timed out. Work around this problem by checking whether we received the data we needed instead of checking timeout condition. Tested-by: Sitsofe Wheeler Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c index 67248c3..be5bbbb 100644 --- a/drivers/input/serio/libps2.c +++ b/drivers/input/serio/libps2.c @@ -210,7 +210,7 @@ int ps2_command(struct ps2dev *ps2dev, unsigned char *param, int command) timeout = wait_event_timeout(ps2dev->wait, !(ps2dev->flags & PS2_FLAG_CMD1), timeout); - if (ps2dev->cmdcnt && timeout > 0) { + if (ps2dev->cmdcnt && !(ps2dev->flags & PS2_FLAG_CMD1)) { timeout = ps2_adjust_timeout(ps2dev, command, timeout); wait_event_timeout(ps2dev->wait,