From: Jarkko Pöyry Date: Mon, 12 Jan 2015 21:52:22 +0000 (-0800) Subject: Fix undefined behavior in record_variable_selection test. X-Git-Tag: upstream/0.1.0~2008 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a3c1058eb8af4c3440cf1223e5e60e5876174f0c;p=platform%2Fupstream%2FVK-GL-CTS.git Fix undefined behavior in record_variable_selection test. Tessellation shader expects patch size >= 3. Increase shader input patch size to 3 from 1. Bug: 18917835 Change-Id: I0eeadfca3690a1a1697aff538699d617b4bee93e --- diff --git a/modules/gles31/functional/es31fTessellationGeometryInteractionTests.cpp b/modules/gles31/functional/es31fTessellationGeometryInteractionTests.cpp index 7e5355a..4e0e920 100644 --- a/modules/gles31/functional/es31fTessellationGeometryInteractionTests.cpp +++ b/modules/gles31/functional/es31fTessellationGeometryInteractionTests.cpp @@ -2866,7 +2866,7 @@ FeedbackRecordVariableSelectionCase::IterateResult FeedbackRecordVariableSelecti m_testCtx.setTestResult(QP_TEST_RESULT_PASS, "Pass"); - m_testCtx.getLog() << tcu::TestLog::Message << "Rendering a patch of size 1." << tcu::TestLog::EndMessage; + m_testCtx.getLog() << tcu::TestLog::Message << "Rendering a patch of size 3." << tcu::TestLog::EndMessage; // Render and feed back @@ -2884,7 +2884,7 @@ FeedbackRecordVariableSelectionCase::IterateResult FeedbackRecordVariableSelecti gl.useProgram(m_program->getProgram()); GLU_EXPECT_NO_ERROR(gl.getError(), "use program"); - gl.patchParameteri(GL_PATCH_VERTICES, 1); + gl.patchParameteri(GL_PATCH_VERTICES, 3); GLU_EXPECT_NO_ERROR(gl.getError(), "set patch param"); gl.bindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, m_xfbBuf); @@ -2893,7 +2893,7 @@ FeedbackRecordVariableSelectionCase::IterateResult FeedbackRecordVariableSelecti gl.beginTransformFeedback(GL_TRIANGLES); GLU_EXPECT_NO_ERROR(gl.getError(), "beginTransformFeedback"); - gl.drawArrays(GL_PATCHES, 0, 1); + gl.drawArrays(GL_PATCHES, 0, 3); GLU_EXPECT_NO_ERROR(gl.getError(), "drawArrays"); gl.endTransformFeedback();