From: Badhri Jagan Sridharan Date: Fri, 7 Apr 2023 03:07:41 +0000 (+0000) Subject: usb: gadget: udc: core: Prevent redundant calls to pullup X-Git-Tag: v6.6.17~5004^2~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a3afbf5cc887fc3401f012fe629810998ed61859;p=platform%2Fkernel%2Flinux-rpi.git usb: gadget: udc: core: Prevent redundant calls to pullup usb_gadget_connect calls gadget->ops->pullup without checking whether gadget->connected was previously set. Make this symmetric to usb_gadget_disconnect by returning early if gadget->connected is already set. Fixes: 5a1da544e572 ("usb: gadget: core: do not try to disconnect gadget if it is not connected") Cc: stable@vger.kernel.org Signed-off-by: Badhri Jagan Sridharan Link: https://lore.kernel.org/r/20230407030741.3163220-2-badhri@google.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index af92c2e..1c5403c 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -703,6 +703,9 @@ static int usb_gadget_connect_locked(struct usb_gadget *gadget) goto out; } + if (gadget->connected) + goto out; + if (gadget->deactivated || !gadget->udc->started) { /* * If gadget is deactivated we only save new state.