From: Dan Carpenter Date: Fri, 8 Nov 2013 09:46:53 +0000 (+0300) Subject: ASoC: rcar: some dubious one-bit signed bitfields X-Git-Tag: upstream/snapshot3+hdmi~3494^2~11^2~38^2^29~19 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a37377314ff068c83f425979142263a17a6f18af;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ASoC: rcar: some dubious one-bit signed bitfields Because these are signed they can either be 0 or -1 instead of 0 and 1 as intended. It doesn't cause a problem from what I can see, but it's dangerous and Sparse complains: sound/soc/sh/rcar/rsnd.h:177:25: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter Signed-off-by: Mark Brown --- diff --git a/sound/soc/sh/rcar/rsnd.h b/sound/soc/sh/rcar/rsnd.h index 9e463e5..b5ac3a2 100644 --- a/sound/soc/sh/rcar/rsnd.h +++ b/sound/soc/sh/rcar/rsnd.h @@ -174,11 +174,11 @@ struct rsnd_dai { struct rsnd_dai_stream playback; struct rsnd_dai_stream capture; - int clk_master:1; - int bit_clk_inv:1; - int frm_clk_inv:1; - int sys_delay:1; - int data_alignment:1; + unsigned int clk_master:1; + unsigned int bit_clk_inv:1; + unsigned int frm_clk_inv:1; + unsigned int sys_delay:1; + unsigned int data_alignment:1; }; #define rsnd_dai_nr(priv) ((priv)->dai_nr)