From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Date: Wed, 19 Mar 2014 12:59:39 +0000 (+0000)
Subject: ALSA: compress: Pass through return value of open ops callback
X-Git-Tag: v3.13.8~45
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a36a33a123dfbcfee9f8b2f9f6af2ffb776a07cf;p=kernel%2Fkernel-generic.git

ALSA: compress: Pass through return value of open ops callback

commit 749d32237bf39e6576dd95bfdf24e4378e51716c upstream.

The snd_compr_open function would always return 0 even if the compressed
ops open function failed, obviously this is incorrect. Looks like this
was introduced by a small typo in:

commit a0830dbd4e42b38aefdf3fb61ba5019a1a99ea85
ALSA: Add a reference counter to card instance

This patch returns the value from the compressed op as it should.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 9d518ac..85fde7e 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -133,7 +133,7 @@ static int snd_compr_open(struct inode *inode, struct file *f)
 		kfree(data);
 	}
 	snd_card_unref(compr->card);
-	return 0;
+	return ret;
 }
 
 static int snd_compr_free(struct inode *inode, struct file *f)