From: Ville Syrjälä Date: Fri, 13 Dec 2013 11:26:20 +0000 (+0200) Subject: drm/i915/bdw: Don't use forcewake needlessly X-Git-Tag: submit/tizen/20160422.055611~1^2~99^2~18^2~2273^2~44^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a3564d2b5236b73bceb271f482965d38cd9d8d8e;p=sdk%2Femulator%2Femulator-kernel.git drm/i915/bdw: Don't use forcewake needlessly Not all registers need forcewake even if they're not shadowed. Add the missing check to gen8_writeX() to avoid needless forcewake usage when writing eg. display registers. v2: Use straight up <0x40000 check instead of NEEDS_FORCE_WAKE() Reviewed-by: Ben Widawsky Signed-off-by: Ville Syrjälä Signed-off-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 32527a74dc46..2c8143c37de3 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm/i915/intel_uncore.c @@ -634,7 +634,7 @@ static bool is_gen8_shadowed(struct drm_i915_private *dev_priv, u32 reg) #define __gen8_write(x) \ static void \ gen8_write##x(struct drm_i915_private *dev_priv, off_t reg, u##x val, bool trace) { \ - bool __needs_put = !is_gen8_shadowed(dev_priv, reg); \ + bool __needs_put = reg < 0x40000 && !is_gen8_shadowed(dev_priv, reg); \ REG_WRITE_HEADER; \ if (__needs_put) { \ dev_priv->uncore.funcs.force_wake_get(dev_priv, \