From: Jiri Slaby Date: Mon, 13 Aug 2012 08:18:09 +0000 (+0200) Subject: TTY: mxser, fix invalid module_parm permissions X-Git-Tag: v3.7-rc1~172^2~123 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a342ca1c78627c3a8b2a8c4e6d5f6ab1b88e6169;p=platform%2Fkernel%2Flinux-3.10.git TTY: mxser, fix invalid module_parm permissions 444 means 0674 and we do not definitely want that. Use S_IRUGO which is much more safer. Signed-off-by: Jiri Slaby Reported-by: Rusty Russell Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index 8bc2651..bb2da4c 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -2338,7 +2338,7 @@ static struct tty_port_operations mxser_port_ops = { */ static bool allow_overlapping_vector; -module_param(allow_overlapping_vector, bool, 444); +module_param(allow_overlapping_vector, bool, S_IRUGO); MODULE_PARM_DESC(allow_overlapping_vector, "whether we allow ISA cards to be configured such that vector overlabs IO ports (default=no)"); static bool mxser_overlapping_vector(struct mxser_board *brd)