From: Chen Zhongjin <chenzhongjin@huawei.com>
Date: Mon, 31 Oct 2022 03:30:53 +0000 (+0800)
Subject: can: af_can: can_exit(): add missing dev_remove_pack() of canxl_packet
X-Git-Tag: v6.1-rc5~24^2~21^2~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a3335faebe1608f3e78e24f09501c9f7d5ebf87a;p=platform%2Fkernel%2Flinux-starfive.git

can: af_can: can_exit(): add missing dev_remove_pack() of canxl_packet

In can_init(), dev_add_pack(&canxl_packet) is added but not removed in
can_exit(). It breaks the packet handler list and can make kernel
panic when can_init() is called for the second time.

| > modprobe can && rmmod can
| > rmmod xxx && modprobe can
|
| BUG: unable to handle page fault for address: fffffbfff807d7f4
| RIP: 0010:dev_add_pack+0x133/0x1f0
| Call Trace:
|  <TASK>
|  can_init+0xaa/0x1000 [can]
|  do_one_initcall+0xd3/0x4e0
|  ...

Fixes: fb08cba12b52 ("can: canxl: update CAN infrastructure for CAN XL frames")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Link: https://lore.kernel.org/all/20221031033053.37849-1-chenzhongjin@huawei.com
[mkl: adjust subject and commit message]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---

diff --git a/net/can/af_can.c b/net/can/af_can.c
index 9503ab1..5e9e3e1 100644
--- a/net/can/af_can.c
+++ b/net/can/af_can.c
@@ -902,6 +902,7 @@ out_pernet:
 static __exit void can_exit(void)
 {
 	/* protocol unregister */
+	dev_remove_pack(&canxl_packet);
 	dev_remove_pack(&canfd_packet);
 	dev_remove_pack(&can_packet);
 	sock_unregister(PF_CAN);