From: Jaeyun <jy1210.jung@samsung.com>
Date: Fri, 23 Nov 2018 03:05:39 +0000 (+0900)
Subject: [Decoder] fix coverity issue
X-Git-Tag: v0.0.3~47
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a31b52c928ff7a79aa5530a2e2553a8e695b2c4f;p=platform%2Fupstream%2Fnnstreamer.git

[Decoder] fix coverity issue

1. init struct detected-object
2. remove macro with no effect (unsigned compare)

Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
---

diff --git a/gst/tensor_decoder/tensordec-boundingbox.c b/gst/tensor_decoder/tensordec-boundingbox.c
index 180bc52..4a05002 100644
--- a/gst/tensor_decoder/tensordec-boundingbox.c
+++ b/gst/tensor_decoder/tensordec-boundingbox.c
@@ -623,7 +623,7 @@ typedef struct
     _type * detinput_ = (_type *) detinput; \
     gsize detbpi = config->info.info[1].dimension[0]; \
     int num = (DETECTION_MAX > bb->max_detection) ? bb->max_detection : DETECTION_MAX; \
-    detectedObject object; \
+    detectedObject object = { .valid = FALSE, .class_id = 0, .x = 0, .y = 0, .width = 0, .height = 0, .prob = 0 }; \
     for (d = 0; d < num; d++) { \
       _get_object_i (bb, d, boxprior, (boxinput_ + (d * boxbpi)), (detinput_ + (d * detbpi)), (&object)); \
       if (object.valid == TRUE) { \
@@ -730,11 +730,11 @@ draw (GstMapInfo * out_info, bounding_boxes * bdata, GArray * results)
     detectedObject *a = &g_array_index (results, detectedObject, i);
 
     /* 1. Draw Boxes */
-    x1 = MAX (0, (bdata->width * a->x) / bdata->i_width);
+    x1 = (bdata->width * a->x) / bdata->i_width;
     x2 = MIN (bdata->width - 1,
         (bdata->width * (a->x + a->width)) / bdata->i_width);
 
-    y1 = MAX (0, (bdata->height * a->y) / bdata->i_height);
+    y1 = (bdata->height * a->y) / bdata->i_height;
     y2 = MIN (bdata->height - 1,
         (bdata->height * (a->y + a->height)) / bdata->i_height);