From: Miaohe Lin <linmiaohe@huawei.com>
Date: Fri, 29 Apr 2022 06:16:05 +0000 (-0700)
Subject: mm/z3fold: remove confusing local variable l reassignment
X-Git-Tag: v6.6.17~7438^2~334
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a3148b5fea52d86b8d1c2445b09ca1033f29fdf0;p=platform%2Fkernel%2Flinux-rpi.git

mm/z3fold: remove confusing local variable l reassignment

The local variable l holds the address of unbuddied[i] which won't change
after we take the pool lock.  Remove it to avoid confusion.

Link: https://lkml.kernel.org/r/20220308134311.59086-6-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/mm/z3fold.c b/mm/z3fold.c
index 2f848ea..adc0b3f 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -876,7 +876,6 @@ lookup:
 
 		/* Re-check under lock. */
 		spin_lock(&pool->lock);
-		l = &unbuddied[i];
 		if (unlikely(zhdr != list_first_entry(READ_ONCE(l),
 						struct z3fold_header, buddy)) ||
 		    !z3fold_page_trylock(zhdr)) {