From: Jeff Garzik <jgarzik@pobox.com>
Date: Thu, 17 Nov 2005 10:44:44 +0000 (-0500)
Subject: [libata sata_mv] handle lack of hardware nIEN support
X-Git-Tag: v3.12-rc1~40358^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a2c91a8819e315e9fd1aef3ff57badb6c1be3f80;p=kernel%2Fkernel-generic.git

[libata sata_mv] handle lack of hardware nIEN support

Handle errata (it was unintentional on this h/w, whereas its intentional
on others) whereby the nIEN bit in Device Control is ignored, leading to
a situation where a hardware interrupt completes the qc before the
polling code has a chance to.

This will get fixed The Right Way(tm) once Albert Lee's irq-pio
branch is merged, as the more natural PIO method on this hardware is
interrupt-driven.
---

diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
index ee0634d..ac184e6 100644
--- a/drivers/scsi/sata_mv.c
+++ b/drivers/scsi/sata_mv.c
@@ -1219,6 +1219,10 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
 			handled++;
 		}
 
+		if (ap &&
+		    (ap->flags & (ATA_FLAG_PORT_DISABLED | ATA_FLAG_NOINTR)))
+			continue;
+
 		err_mask = ac_err_mask(ata_status);
 
 		shift = port << 1;		/* (port * 2) */
@@ -1237,7 +1241,8 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
 				VPRINTK("port %u IRQ found for qc, "
 					"ata_status 0x%x\n", port,ata_status);
 				/* mark qc status appropriately */
-				ata_qc_complete(qc, err_mask);
+				if (!(qc->tf.ctl & ATA_NIEN))
+					ata_qc_complete(qc, err_mask);
 			}
 		}
 	}