From: Atul Gopinathan Date: Mon, 3 May 2021 11:57:02 +0000 (+0200) Subject: ALSA: sb8: Add a comment note regarding an unused pointer X-Git-Tag: accepted/tizen/unified/20230118.172025~7200^2~42 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a28591f61b60fac820c6de59826ffa710e5e314e;p=platform%2Fkernel%2Flinux-rpi.git ALSA: sb8: Add a comment note regarding an unused pointer The field "fm_res" of "struct snd_sb8" is never used/dereferenced throughout the sb8.c code. Therefore there is no need for any null value check after the "request_region()". Add a comment note to make developers know about this and prevent any "NULL check" patches on this part of code. Cc: Takashi Iwai Signed-off-by: Atul Gopinathan Link: https://lore.kernel.org/r/20210503115736.2104747-36-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c index 95290ff..ed3a87e 100644 --- a/sound/isa/sb/sb8.c +++ b/sound/isa/sb/sb8.c @@ -93,7 +93,11 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev) acard = card->private_data; card->private_free = snd_sb8_free; - /* block the 0x388 port to avoid PnP conflicts */ + /* + * Block the 0x388 port to avoid PnP conflicts. + * No need to check this value after request_region, + * as we never do anything with it. + */ acard->fm_res = request_region(0x388, 4, "SoundBlaster FM"); if (port[dev] != SNDRV_AUTO_PORT) {