From: Hans Verkuil Date: Fri, 9 Dec 2016 13:28:19 +0000 (-0200) Subject: [media] cec: CEC_MSG_GIVE_FEATURES should abort for CEC version < 2 X-Git-Tag: v4.11-rc2~21^2~249 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a24f56d47930492c94ef6875bf45adf7607ca1a4;p=platform%2Fkernel%2Flinux-exynos.git [media] cec: CEC_MSG_GIVE_FEATURES should abort for CEC version < 2 This is a 2.0 only message, so it should return Feature Abort if the adapter is configured for CEC version 1.4. Right now it does nothing, which means that the sender will time out. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/cec/cec-adap.c b/drivers/media/cec/cec-adap.c index 3191c0c..c05956f 100644 --- a/drivers/media/cec/cec-adap.c +++ b/drivers/media/cec/cec-adap.c @@ -1777,9 +1777,9 @@ static int cec_receive_notify(struct cec_adapter *adap, struct cec_msg *msg, } case CEC_MSG_GIVE_FEATURES: - if (adap->log_addrs.cec_version >= CEC_OP_CEC_VERSION_2_0) - return cec_report_features(adap, la_idx); - return 0; + if (adap->log_addrs.cec_version < CEC_OP_CEC_VERSION_2_0) + return cec_feature_abort(adap, msg); + return cec_report_features(adap, la_idx); default: /*