From: Tony Wasserka Date: Thu, 5 Nov 2020 11:43:14 +0000 (+0100) Subject: aco/tests: Allow specifiying the test subvariant in setup_cs X-Git-Tag: upstream/21.0.0~1007 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a240341ec94b3932ebe8b3a4fe014833380eb29f;p=platform%2Fupstream%2Fmesa.git aco/tests: Allow specifiying the test subvariant in setup_cs Reviewed-by: Daniel Schürmann Part-of: --- diff --git a/src/amd/compiler/tests/helpers.cpp b/src/amd/compiler/tests/helpers.cpp index 724c86b..f0ab616 100644 --- a/src/amd/compiler/tests/helpers.cpp +++ b/src/amd/compiler/tests/helpers.cpp @@ -43,7 +43,6 @@ std::unique_ptr program; Builder bld(NULL); Temp inputs[16]; Temp exec_input; -const char *subvariant = ""; static VkInstance instance_cache[CHIP_LAST] = {VK_NULL_HANDLE}; static VkDevice device_cache[CHIP_LAST] = {VK_NULL_HANDLE}; @@ -94,11 +93,10 @@ void create_program(enum chip_class chip_class, Stage stage, unsigned wave_size, } bool setup_cs(const char *input_spec, enum chip_class chip_class, - enum radeon_family family, unsigned wave_size) + enum radeon_family family, const char* subvariant, + unsigned wave_size) { - const char *old_subvariant = subvariant; - subvariant = ""; - if (!set_variant(chip_class, old_subvariant)) + if (!set_variant(chip_class, subvariant)) return false; memset(&info, 0, sizeof(info)); diff --git a/src/amd/compiler/tests/helpers.h b/src/amd/compiler/tests/helpers.h index 11fa546..3ce9fab 100644 --- a/src/amd/compiler/tests/helpers.h +++ b/src/amd/compiler/tests/helpers.h @@ -66,12 +66,12 @@ extern std::unique_ptr program; extern aco::Builder bld; extern aco::Temp exec_input; extern aco::Temp inputs[16]; -extern const char *subvariant; void create_program(enum chip_class chip_class, aco::Stage stage, unsigned wave_size=64, enum radeon_family family=CHIP_UNKNOWN); bool setup_cs(const char *input_spec, enum chip_class chip_class, - enum radeon_family family=CHIP_UNKNOWN, unsigned wave_size=64); + enum radeon_family family=CHIP_UNKNOWN, const char* subvariant = "", + unsigned wave_size=64); void finish_program(aco::Program *program); void finish_validator_test(); diff --git a/src/amd/compiler/tests/test_optimizer.cpp b/src/amd/compiler/tests/test_optimizer.cpp index da00fce..08cd7d1 100644 --- a/src/amd/compiler/tests/test_optimizer.cpp +++ b/src/amd/compiler/tests/test_optimizer.cpp @@ -521,9 +521,7 @@ static const clamp_config clamp_configs[] = { BEGIN_TEST(optimize.clamp) for (clamp_config cfg : clamp_configs) { - subvariant = cfg.name; - - if (!setup_cs("v1 v1 v1", GFX9)) + if (!setup_cs("v1 v1 v1", GFX9, CHIP_UNKNOWN, cfg.name)) continue; //! cfg: @match_func(min max med3 lb ub)