From: Thomas Meyer Date: Tue, 29 Nov 2011 11:08:00 +0000 (+0000) Subject: enic: Use kcalloc instead of kzalloc to allocate array X-Git-Tag: v3.3-rc1~182^2~363 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a1de22191bc4c47ff50ef3274295f4384074696b;p=profile%2Fivi%2Fkernel-x86-ivi.git enic: Use kcalloc instead of kzalloc to allocate array The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index 1fe5df0..2fd9db4 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -2379,7 +2379,7 @@ static int __devinit enic_probe(struct pci_dev *pdev, #endif /* Allocate structure for port profiles */ - enic->pp = kzalloc(num_pps * sizeof(*enic->pp), GFP_KERNEL); + enic->pp = kcalloc(num_pps, sizeof(*enic->pp), GFP_KERNEL); if (!enic->pp) { pr_err("port profile alloc failed, aborting\n"); err = -ENOMEM;