From: SangYoun Kwak Date: Tue, 12 Mar 2024 07:57:39 +0000 (+0900) Subject: mass-delta-builder: Remove unused enum values X-Git-Tag: accepted/tizen/unified/20240419.110853~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a1cb263d323b07e3fe07c761dae48b6f53243216;p=platform%2Fcore%2Fsystem%2Fupgrade-tools.git mass-delta-builder: Remove unused enum values In the enum "DeltaType", there were values named "kernel", "system", but they are not used. (DeltaType was checked only if it is "full" or not) These unused enum values are removed. Also their values are defined with 'enum.auto()' function instead of integer value since it is better to distinguish enum elements when the new element is added or element is removed. Change-Id: I607c9358f6c03ae4a333d21705c0775d731b1b10 Signed-off-by: SangYoun Kwak --- diff --git a/mass-delta-builder/mass-delta-builder.py b/mass-delta-builder/mass-delta-builder.py index 2249606..f70372d 100755 --- a/mass-delta-builder/mass-delta-builder.py +++ b/mass-delta-builder/mass-delta-builder.py @@ -18,7 +18,7 @@ import logging import sys import base64 import pickle -from enum import Enum +from enum import Enum, auto from urllib.parse import urlparse, urljoin import requests import yaml @@ -52,29 +52,19 @@ class TotaDirType(Enum): class DeltaType(Enum): - all = 1 - kernel = 2 - system = 3 - full = 4 + all = auto() + full = auto() @staticmethod def parse(string): if string == 'all': return DeltaType.all - if string == 'kernel': - return DeltaType.kernel - if string == 'system': - return DeltaType.system if string == 'full': return DeltaType.full def __str__(self): if self == DeltaType.all: return 'all' - if self == DeltaType.kernel: - return 'kernel' - if self == DeltaType.system: - return 'system' if self == DeltaType.full: return 'full' @@ -153,10 +143,10 @@ class UrlProvider: def get_urls_for(self, delta_order, snapshot, release_type): links = [] - if delta_order.delta_type in [DeltaType.all, DeltaType.system, DeltaType.full]: + if delta_order.delta_type in [DeltaType.all, DeltaType.full]: links.append(self._get_url_for(delta_order, snapshot, release_type, ImageType.system)) - if delta_order.delta_type in [DeltaType.all, DeltaType.kernel, DeltaType.full]: + if delta_order.delta_type in [DeltaType.all, DeltaType.full]: links.append(self._get_url_for(delta_order, snapshot, release_type, ImageType.boot)) return links @@ -418,7 +408,7 @@ class OrderMaker: if one_set.get('disabled', False): continue for arch in one_set['arch']: - if one_set['image_type'] in ['all', 'system', 'full']: + if one_set['image_type'] in ['all', 'full']: for profile in one_set['profiles']: orders = self._gen_order_for_all_snapshots(one_set, arch, profile) all_orders += orders