From: Osama Muhammad Date: Fri, 26 May 2023 16:39:38 +0000 (+0500) Subject: hwmon: (pmbus/adm1266) Drop unnecessary error check for debugfs_create_dir X-Git-Tag: v6.6.7~2533^2~25 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a1b6f13578e15e09fdaee5d90f05de04b59240bd;p=platform%2Fkernel%2Flinux-starfive.git hwmon: (pmbus/adm1266) Drop unnecessary error check for debugfs_create_dir This patch removes the error checking for debugfs_create_dir in adm1266.c. This is because the debugfs_create_dir() does not return NULL but an ERR_PTR after an error. The DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.The debugfs Api handles it gracefully. The check is unnecessary. Link to the comment above debugfs_create_dir: https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565 Signed-off-by: Osama Muhammad Link: https://lore.kernel.org/r/20230526163938.9903-1-osmtendev@gmail.com Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c index aba7033..ed0a7b9 100644 --- a/drivers/hwmon/pmbus/adm1266.c +++ b/drivers/hwmon/pmbus/adm1266.c @@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data) return; data->debugfs_dir = debugfs_create_dir(data->client->name, root); - if (!data->debugfs_dir) - return; debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir, adm1266_state_read);