From: Linus Torvalds Date: Sun, 25 Jul 2021 18:06:37 +0000 (-0700) Subject: smpboot: fix duplicate and misplaced inlining directive X-Git-Tag: accepted/tizen/unified/20230118.172025~6751 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a1833a54033e4ca760ad58fa2a6469ad59b3fa1a;p=platform%2Fkernel%2Flinux-rpi.git smpboot: fix duplicate and misplaced inlining directive gcc doesn't care, but clang quite reasonably pointed out that the recent commit e9ba16e68cce ("smpboot: Mark idle_init() as __always_inlined to work around aggressive compiler un-inlining") did some really odd things: kernel/smpboot.c:50:20: warning: duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier] static inline void __always_inline idle_init(unsigned int cpu) ^ which not only has that duplicate inlining specifier, but the new __always_inline was put in the wrong place of the function definition. We put the storage class specifiers (ie things like "static" and "extern") first, and the type information after that. And while the compiler may not care, we put the inline specifier before the types. So it should be just static __always_inline void idle_init(unsigned int cpu) instead. Cc: Ingo Molnar Cc: Thomas Gleixner Signed-off-by: Linus Torvalds --- diff --git a/kernel/smpboot.c b/kernel/smpboot.c index 21b7953..cf6acab 100644 --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -47,7 +47,7 @@ void __init idle_thread_set_boot_cpu(void) * * Creates the thread if it does not exist. */ -static inline void __always_inline idle_init(unsigned int cpu) +static __always_inline void idle_init(unsigned int cpu) { struct task_struct *tsk = per_cpu(idle_threads, cpu);