From: Barnabás Pőcze Date: Wed, 3 Feb 2021 21:54:16 +0000 (+0000) Subject: platform/x86: ideapad-laptop: remove unnecessary dev_set_drvdata() call X-Git-Tag: v5.15~1725^2~40 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a14b3c83ab435e0a06f83a2c519ad27baf805cba;p=platform%2Fkernel%2Flinux-starfive.git platform/x86: ideapad-laptop: remove unnecessary dev_set_drvdata() call The driver core already sets the driver specific data on bind failure or removal. Thus the call is unnecessary. Signed-off-by: Barnabás Pőcze Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20210203215403.290792-2-pobrn@protonmail.com Signed-off-by: Hans de Goede --- diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index cc42af2..18c71e2 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -1369,7 +1369,6 @@ static int ideapad_acpi_remove(struct platform_device *pdev) ideapad_input_exit(priv); ideapad_debugfs_exit(priv); ideapad_sysfs_exit(priv); - dev_set_drvdata(&pdev->dev, NULL); return 0; }