From: Jan Alexander Steffens (heftig) <jan.steffens@ltnglobal.com>
Date: Wed, 1 Dec 2021 15:13:42 +0000 (+0100)
Subject: rtmp2/client: Make sure 'desc' is not NULL
X-Git-Tag: 1.22.0~555
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a13f234be330e20e6bdd5cf758fe9a15d40a506a;p=platform%2Fupstream%2Fgstreamer.git

rtmp2/client: Make sure 'desc' is not NULL

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1403>
---

diff --git a/subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c b/subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c
index b5784e5..7fba3a7 100644
--- a/subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c
+++ b/subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c
@@ -746,15 +746,15 @@ send_connect_done (const gchar * command_name, GPtrArray * args,
     GstUri *query;
 
     node = gst_amf_node_get_field (optional_args, "description");
-    if (!node) {
+    desc = node ? gst_amf_node_peek_string (node, NULL) : NULL;
+    if (!desc) {
       g_task_return_new_error (task, G_IO_ERROR, G_IO_ERROR_PERMISSION_DENIED,
           "Connect rejected; no description");
       g_object_unref (task);
       return;
     }
 
-    desc = gst_amf_node_peek_string (node, NULL);
-    GST_DEBUG ("connect result desc: %s", GST_STR_NULL (desc));
+    GST_DEBUG ("connect result desc: %s", desc);
 
     if (authmod == GST_RTMP_AUTHMOD_AUTO && strstr (desc, "code=403 need auth")) {
       if (strstr (desc, "authmod=adobe")) {