From: Jason McDonald Date: Mon, 31 Oct 2011 02:30:14 +0000 (+1000) Subject: Improve QBuffer autotest X-Git-Tag: qt-v5.0.0-alpha1~2980 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a13b24eac09fec5da41fec63c8db986e7121d1c6;p=profile%2Fivi%2Fqtbase.git Improve QBuffer autotest The documentation of QIODevice::pos() states: "For sequential devices or closed devices, where there is no concept of a "current position", 0 is returned". The test had a disabled check for a position of -1 before the device is opened. Make the test agree with the documentation. Change-Id: Ide5729bfc825cdb84caf4851574a57d3ef42ccb2 Reviewed-by: Rohan McGovern --- diff --git a/tests/auto/corelib/io/qbuffer/tst_qbuffer.cpp b/tests/auto/corelib/io/qbuffer/tst_qbuffer.cpp index bf4842f..0306323 100644 --- a/tests/auto/corelib/io/qbuffer/tst_qbuffer.cpp +++ b/tests/auto/corelib/io/qbuffer/tst_qbuffer.cpp @@ -328,9 +328,8 @@ void tst_QBuffer::seekTest() QByteArray ba; QBuffer buf(&ba); -#if 0 - QCOMPARE(buf.pos(), qint64(-1)); -#endif + QCOMPARE(buf.pos(), qint64(0)); + buf.open(QIODevice::ReadWrite); QCOMPARE(buf.pos(), qint64(0));