From: Francesco Dolcini Date: Mon, 19 Jun 2023 15:44:35 +0000 (+0200) Subject: Revert "net: phy: dp83867: perform soft reset and retain established link" X-Git-Tag: v6.6.7~2638^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a129b41fe0a8b4da828c46b10f5244ca07a3fec3;p=platform%2Fkernel%2Flinux-starfive.git Revert "net: phy: dp83867: perform soft reset and retain established link" This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a. This fixes a regression in which the link would come up, but no communication was possible. The reverted commit was also removing a comment about DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits since it seems that this is unrelated to the original code change. Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/ Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link") Signed-off-by: Francesco Dolcini Reviewed-by: Andrew Lunn Reviewed-by: Praneeth Bajjuri Link: https://lore.kernel.org/r/20230619154435.355485-1-francesco@dolcini.it Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 76f5a24..e397e7d 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -936,7 +936,7 @@ static int dp83867_phy_reset(struct phy_device *phydev) { int err; - err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESTART); + err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESET); if (err < 0) return err;