From: Geert Uytterhoeven Date: Thu, 7 Aug 2014 12:07:43 +0000 (+0200) Subject: spi: sh-msiof: Fix transmit-only DMA transfers X-Git-Tag: upstream/snapshot3+hdmi~291 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a0dbdee1d9dd6704b6a97fdb0d17914f98a6dab6;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git spi: sh-msiof: Fix transmit-only DMA transfers Fix tx/rx mixup, which broke transmit-only transfers. Introduced by commit 4240305f7cbdc7782aa8bc40cc702775d9ac0839 ("spi: sh-msiof: Fix leaking of unused DMA descriptors"). Reported-by: Laurent Pinchart Signed-off-by: Geert Uytterhoeven Acked-by: Laurent Pinchart Signed-off-by: Mark Brown (cherry picked from commit cdcd565fa0925edf9b80c875fcc84a231c75bd1d) Signed-off-by: Simon Horman --- diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c index 887c208..543075b 100644 --- a/drivers/spi/spi-sh-msiof.c +++ b/drivers/spi/spi-sh-msiof.c @@ -693,9 +693,9 @@ static int sh_msiof_dma_once(struct sh_msiof_spi_priv *p, const void *tx, reinit_completion(&p->done); /* Now start DMA */ - if (tx) - dma_async_issue_pending(p->master->dma_rx); if (rx) + dma_async_issue_pending(p->master->dma_rx); + if (tx) dma_async_issue_pending(p->master->dma_tx); ret = sh_msiof_spi_start(p, rx);