From: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Date: Mon, 7 Nov 2011 22:36:11 +0000 (+0000)
Subject:    if (fail) goto exit;
X-Git-Tag: submit/efl/20131021.015651~5437
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a0c180f41a8b9c1153f64a30c0e0af6e8ba1fb8c;p=platform%2Fupstream%2Fenlightenment.git

   if (fail) goto exit;
exit:
   return;

who can spot what's wrong with the above snippet? cookies for the first one to answer correctly!


SVN revision: 64886
---

diff --git a/src/bin/e_randr.c b/src/bin/e_randr.c
index 2217e14..75d2b33 100644
--- a/src/bin/e_randr.c
+++ b/src/bin/e_randr.c
@@ -724,7 +724,7 @@ _e_randr_event_cb(void *data __UNUSED__, int type, void *ev)
            };
            */
         crtc_info = _e_randr_crtc_info_get(event->crtc);
-	if (!crtc_info) goto on_exit;
+	if (!crtc_info) return ECORE_CALLBACK_RENEW;
 
         if (event->mode != Ecore_X_Randr_None)
           {
@@ -793,7 +793,7 @@ _e_randr_event_cb(void *data __UNUSED__, int type, void *ev)
                 event->win, event->output, event->crtc, event->mode, event->orientation, event->connection, ECORE_X_RANDR_CONNECTION_STATUS_CONNECTED, ECORE_X_RANDR_CONNECTION_STATUS_DISCONNECTED, ECORE_X_RANDR_CONNECTION_STATUS_UNKNOWN, event->subpixel_order);
 
         output_info = _e_randr_output_info_get(event->output);
-        if (!output_info) goto on_exit;
+        if (!output_info) return ECORE_CALLBACK_RENEW;
         
         if ((output_info->crtc = _e_randr_crtc_info_get(event->crtc)))
           {
@@ -878,7 +878,6 @@ _e_randr_event_cb(void *data __UNUSED__, int type, void *ev)
            */
      }
    e_randr_try_restore_configuration(e_randr_screen_info);
- on_exit:
    return ECORE_CALLBACK_RENEW;
 }