From: Dan Carpenter Date: Wed, 8 Sep 2021 05:33:57 +0000 (+0300) Subject: tpm: Check for integer overflow in tpm2_map_response_body() X-Git-Tag: v6.1-rc5~2827^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a0bcce2b2a169e10eb265c8f0ebdd5ae4c875670;p=platform%2Fkernel%2Flinux-starfive.git tpm: Check for integer overflow in tpm2_map_response_body() The "4 * be32_to_cpu(data->count)" multiplication can potentially overflow which would lead to memory corruption. Add a check for that. Cc: stable@vger.kernel.org Fixes: 745b361e989a ("tpm: infrastructure for TPM spaces") Signed-off-by: Dan Carpenter Reviewed-by: Jarkko Sakkinen Signed-off-by: Jarkko Sakkinen --- diff --git a/drivers/char/tpm/tpm2-space.c b/drivers/char/tpm/tpm2-space.c index 784b8b3..97e9168 100644 --- a/drivers/char/tpm/tpm2-space.c +++ b/drivers/char/tpm/tpm2-space.c @@ -455,6 +455,9 @@ static int tpm2_map_response_body(struct tpm_chip *chip, u32 cc, u8 *rsp, if (be32_to_cpu(data->capability) != TPM2_CAP_HANDLES) return 0; + if (be32_to_cpu(data->count) > (UINT_MAX - TPM_HEADER_SIZE - 9) / 4) + return -EFAULT; + if (len != TPM_HEADER_SIZE + 9 + 4 * be32_to_cpu(data->count)) return -EFAULT;