From: Arnaldo Carvalho de Melo Date: Tue, 14 Feb 2017 19:19:56 +0000 (-0300) Subject: perf tools: Be consistent on the type of map->symbols[] interator X-Git-Tag: v4.14-rc1~1511^2^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a0b2f5af4c99d3da7ce9bc2b3b4641c8ffd22615;p=platform%2Fkernel%2Flinux-rpi.git perf tools: Be consistent on the type of map->symbols[] interator In a few cases we were using 'enum map_type' and that triggered this warning when using clang: util/session.c:1923:16: error: comparison of constant 2 with expression of type 'enum map_type' is always true [-Werror,-Wtautological-constant-out-of-range-compare] for (i = 0; i < MAP__NR_TYPES; ++i) { Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-i6uyo6bsopa2dghnx8qo7rri@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index a1043cf..71c9720 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -782,7 +782,7 @@ static u64 machine__get_running_kernel_start(struct machine *machine, int __machine__create_kernel_maps(struct machine *machine, struct dso *kernel) { - enum map_type type; + int type; u64 start = machine__get_running_kernel_start(machine, NULL); /* In case of renewal the kernel map, destroy previous one */ @@ -813,7 +813,7 @@ int __machine__create_kernel_maps(struct machine *machine, struct dso *kernel) void machine__destroy_kernel_maps(struct machine *machine) { - enum map_type type; + int type; for (type = 0; type < MAP__NR_TYPES; ++type) { struct kmap *kmap; diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 349c681..4cdbc8f 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1901,7 +1901,7 @@ int maps__set_kallsyms_ref_reloc_sym(struct map **maps, const char *symbol_name, u64 addr) { char *bracket; - enum map_type i; + int i; struct ref_reloc_sym *ref; ref = zalloc(sizeof(struct ref_reloc_sym));