From: Max Filippov Date: Sun, 27 Mar 2016 17:45:54 +0000 (+0300) Subject: gdb: xtensa: fix frame initialization when PC is invalid X-Git-Tag: binutils-2_27~964 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a08b52b5c45195c0b095215f19422d2ab67a3a8d;p=external%2Fbinutils.git gdb: xtensa: fix frame initialization when PC is invalid When gdb is used on core dump and PC is not pointing to a readable memory read_memory_integer call in the xtensa_frame_cache throws an error, making register inspection/backtracing impossible in that thread. Use safe_read_memory_integer instead. 2016-03-29 Max Filippov gdb/ * xtensa-tdep.c (xtensa_frame_cache): Change op1 type to LONGEST. Use safe_read_memory_integer instead of read_memory_integer. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 25afbef..0c76434 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2016-03-29 Max Filippov + + * xtensa-tdep.c (xtensa_frame_cache): Change op1 type to LONGEST. + Use safe_read_memory_integer instead of read_memory_integer. + 2016-03-29 Marcin Kościelnicki * NEWS: Mention support for tracepoints on s390*-linux. diff --git a/gdb/xtensa-tdep.c b/gdb/xtensa-tdep.c index 9e87fa5..3a3bada 100644 --- a/gdb/xtensa-tdep.c +++ b/gdb/xtensa-tdep.c @@ -1285,7 +1285,7 @@ xtensa_frame_cache (struct frame_info *this_frame, void **this_cache) if (windowed) { - char op1; + LONGEST op1; /* Get WINDOWBASE, WINDOWSTART, and PS registers. */ wb = get_frame_register_unsigned (this_frame, @@ -1293,8 +1293,8 @@ xtensa_frame_cache (struct frame_info *this_frame, void **this_cache) ws = get_frame_register_unsigned (this_frame, gdbarch_tdep (gdbarch)->ws_regnum); - op1 = read_memory_integer (pc, 1, byte_order); - if (XTENSA_IS_ENTRY (gdbarch, op1)) + if (safe_read_memory_integer (pc, 1, byte_order, &op1) + && XTENSA_IS_ENTRY (gdbarch, op1)) { int callinc = CALLINC (ps); ra = get_frame_register_unsigned