From: Peter Hutterer <peter.hutterer@who-t.net>
Date: Tue, 17 Oct 2017 06:55:27 +0000 (+1000)
Subject: test: unref the litest device *after* removing it from the path interface
X-Git-Tag: 1.9.0~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a06256d1c3c81a1314516f29d9f732ec4eae195f;p=platform%2Fupstream%2Flibinput.git

test: unref the litest device *after* removing it from the path interface

Our own reference may be the last one that's still alive if the context is
currently suspended (litest_suspend()). If we unref before removing it from
the path interface, we access already freed memory.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Jonas Ådahl <jadahl@gmail.com>
---

diff --git a/test/litest.c b/test/litest.c
index 4f26771f..d34bd3c5 100644
--- a/test/litest.c
+++ b/test/litest.c
@@ -1341,8 +1341,8 @@ litest_delete_device(struct litest_device *d)
 	litest_assert_int_eq(d->skip_ev_syn, 0);
 
 	if (d->libinput_device) {
-		libinput_device_unref(d->libinput_device);
 		libinput_path_remove_device(d->libinput_device);
+		libinput_device_unref(d->libinput_device);
 	}
 	if (d->owns_context)
 		libinput_unref(d->libinput);