From: DJ Delorie <dj@redhat.com>
Date: Fri, 13 Dec 2019 18:36:58 +0000 (-0500)
Subject: tunables: report sbrk() failure
X-Git-Tag: upstream/2.34~2492
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a059f9505bbef1f22c6f52798a74184632929145;p=platform%2Fupstream%2Fglibc.git

tunables: report sbrk() failure

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
---

diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c
index e625ac1..f0d7d42 100644
--- a/elf/dl-tunables.c
+++ b/elf/dl-tunables.c
@@ -45,12 +45,11 @@ tunables_strdup (const char *in)
   while (in[i++] != '\0');
   char *out = __sbrk (i);
 
-  /* FIXME: In reality if the allocation fails, __sbrk will crash attempting to
-     set the thread-local errno since the TCB has not yet been set up.  This
-     needs to be fixed with an __sbrk implementation that does not set
-     errno.  */
+  /* For most of the tunables code, we ignore user errors.  However,
+     this is a system error - and running out of memory at program
+     startup should be reported, so we do.  */
   if (out == (void *)-1)
-    return NULL;
+    _dl_fatal_printf ("sbrk() failure while processing tunables\n");
 
   i--;