From: Alex Elder <elder@inktank.com>
Date: Thu, 19 Jul 2012 14:09:27 +0000 (-0500)
Subject: rbd: simplify __rbd_remove_all_snaps()
X-Git-Tag: v3.6-rc1~36^2~35
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a05932905695f8c6c06d353ecd52c8e5d607cc77;p=platform%2Fkernel%2Flinux-3.10.git

rbd: simplify __rbd_remove_all_snaps()

This just replaces a while loop with list_for_each_entry_safe()
in __rbd_remove_all_snaps().

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
---

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index b9895fe..74e6a33 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -1692,11 +1692,10 @@ bad:
 static void __rbd_remove_all_snaps(struct rbd_device *rbd_dev)
 {
 	struct rbd_snap *snap;
+	struct rbd_snap *next;
 
-	while (!list_empty(&rbd_dev->snaps)) {
-		snap = list_first_entry(&rbd_dev->snaps, struct rbd_snap, node);
+	list_for_each_entry_safe(snap, next, &rbd_dev->snaps, node)
 		__rbd_remove_snap_dev(rbd_dev, snap);
-	}
 }
 
 /*