From: Clement Calmels Date: Sun, 13 Dec 2015 05:20:11 +0000 (-0800) Subject: Input: xpad - remove spurious events of wireless xpad 360 controller X-Git-Tag: v3.18.128~50 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a03c1ce2b727c73b81e3a0fca3d43f065ff49256;p=profile%2Fwearable%2Fplatform%2Fkernel%2Flinux-3.18-exynos7270.git Input: xpad - remove spurious events of wireless xpad 360 controller [ Upstream commit 93a017aa2f77291752e637bfd83f2459dba714cb ] When powering up a wireless xbox 360 controller, some wrong joystick events are generated. It is annoying because, for example, it makes unwanted moves in Steam big picture mode's menu. When my controller is powering up, this packet is received by the driver: 00000000: 00 0f 00 f0 00 cc ff cf 8b e0 86 6a 68 f0 00 20 ...........jh.. 00000010: 13 e3 20 1d 30 03 40 01 50 01 ff ff .. .0.@.P... According to xboxdrv userspace driver source code, this packet is only dumping a serial id and should not be interpreted as joystick events. This issue can be easily seen with jstest: $ jstest --event /dev/input/js0 This patch only adds a way to filter out this "serial" packet and as a result it removes the spurous events. Signed-off-by: Clement Calmels Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 1a66443..33c3071 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -529,7 +529,7 @@ static void xpad360w_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned cha } /* Valid pad data */ - if (!(data[1] & 0x1)) + if (data[1] != 0x1) return; xpad360_process_packet(xpad, cmd, &data[4]);