From: Takashi Iwai <tiwai@suse.de>
Date: Thu, 7 Sep 2017 08:59:16 +0000 (+0200)
Subject: ASoC: tas571x: Kill BUG_ON() usage
X-Git-Tag: v4.19~1622^2~4^2~6^6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a029ef45179d72945c7ae0a11f97e8012a5574ac;p=platform%2Fkernel%2Flinux-rpi.git

ASoC: tas571x: Kill BUG_ON() usage

Don't use BUG_ON() for a non-critical sanity check on production
systems.  This patch replaces with a softer WARN_ON() and an error
path.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/sound/soc/codecs/tas571x.c b/sound/soc/codecs/tas571x.c
index 810369f..a094999 100644
--- a/sound/soc/codecs/tas571x.c
+++ b/sound/soc/codecs/tas571x.c
@@ -697,7 +697,8 @@ static int tas571x_i2c_probe(struct i2c_client *client,
 		return PTR_ERR(priv->mclk);
 	}
 
-	BUG_ON(priv->chip->num_supply_names > TAS571X_MAX_SUPPLIES);
+	if (WARN_ON(priv->chip->num_supply_names > TAS571X_MAX_SUPPLIES))
+		return -EINVAL;
 	for (i = 0; i < priv->chip->num_supply_names; i++)
 		priv->supplies[i].supply = priv->chip->supply_names[i];