From: Sam Ravnborg Date: Sun, 19 Jul 2020 08:07:40 +0000 (+0200) Subject: backlight: jornada720_bl: Introduce backlight_is_blank() X-Git-Tag: v5.10.7~1871^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a00a5feb1e96ff55c24131472db53dc56cc7570b;p=platform%2Fkernel%2Flinux-rpi.git backlight: jornada720_bl: Introduce backlight_is_blank() Use the backlight_is_blank() helper to simplify the code a bit. The jornada720_bl driver distinguish between backlight off and brightness set to 0. Thus this driver turn off backlight only when backlight_is_blank() returns true. Signed-off-by: Sam Ravnborg Reviewed-by: Daniel Thompson Signed-off-by: Lee Jones --- diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c index f0385f9..996f7ba 100644 --- a/drivers/video/backlight/jornada720_bl.c +++ b/drivers/video/backlight/jornada720_bl.c @@ -54,7 +54,7 @@ static int jornada_bl_update_status(struct backlight_device *bd) jornada_ssp_start(); /* If backlight is off then really turn it off */ - if ((bd->props.power != FB_BLANK_UNBLANK) || (bd->props.fb_blank != FB_BLANK_UNBLANK)) { + if (backlight_is_blank(bd)) { ret = jornada_ssp_byte(BRIGHTNESSOFF); if (ret != TXDUMMY) { dev_info(&bd->dev, "brightness off timeout\n");