From: Gustavo A. R. Silva Date: Wed, 15 Aug 2018 16:23:49 +0000 (-0500) Subject: iio: health: max30102: Mark expected switch fall-throughs X-Git-Tag: v5.15~7699^2~380^2~50 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9ffa68f65416094714c63ed1db219493e84fe21d;p=platform%2Fkernel%2Flinux-starfive.git iio: health: max30102: Mark expected switch fall-throughs In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case, I placed the "fall through" annotation at the bottom of the case, which is what GCC is expecting to find. Addresses-Coverity-ID: 1458342 ("Missing break in switch") Addresses-Coverity-ID: 1458345 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c index 15ccadc..3e29562 100644 --- a/drivers/iio/health/max30102.c +++ b/drivers/iio/health/max30102.c @@ -282,9 +282,11 @@ static int max30102_read_measurement(struct max30102_data *data, switch (measurements) { case 3: MAX30102_COPY_DATA(2); - case 2: /* fall-through */ + /* fall through */ + case 2: MAX30102_COPY_DATA(1); - case 1: /* fall-through */ + /* fall through */ + case 1: MAX30102_COPY_DATA(0); break; default: