From: Sebastian Dröge Date: Wed, 2 Oct 2013 10:45:44 +0000 (+0200) Subject: avauddec: Don't believe we're negotiated if negotiation failed X-Git-Tag: 1.19.3~499^2~653 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9febec71c0b35ed2ea0b8d24c949013fb57bceda;p=platform%2Fupstream%2Fgstreamer.git avauddec: Don't believe we're negotiated if negotiation failed It can happen that negotiation fails during get_buffer(), but then we don't retry later and never return NOT_NEGOTIATED upstream... and instead run into assertions. https://bugzilla.gnome.org/show_bug.cgi?id=708769 --- diff --git a/ext/libav/gstavauddec.c b/ext/libav/gstavauddec.c index 627dc93..f195ca0 100644 --- a/ext/libav/gstavauddec.c +++ b/ext/libav/gstavauddec.c @@ -441,6 +441,7 @@ caps_failed: GST_ELEMENT_ERROR (ffmpegdec, CORE, NEGOTIATION, (NULL), ("Could not set caps for libav decoder (%s), not fixed?", oclass->in_plugin->name)); + memset (&ffmpegdec->info, 0, sizeof (ffmpegdec->info)); return FALSE; }