From: Oskar Rundgren <oskar.rundgren@imgtec.com>
Date: Wed, 3 May 2023 16:56:13 +0000 (+0100)
Subject: pvr: Transfer PBE source snorm format should be signed
X-Git-Tag: upstream/23.3.3~8592
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9fccc25bdf1f16ecabb832207ef8879b705fcde3;p=platform%2Fupstream%2Fmesa.git

pvr: Transfer PBE source snorm format should be signed

Wrong shader was picked because snorm formats were treated as unsigned.

Signed-off-by: Oskar Rundgren <oskar.rundgren@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22918>
---

diff --git a/src/imagination/vulkan/pvr_job_transfer.c b/src/imagination/vulkan/pvr_job_transfer.c
index 49bdd50..cbe3f7d 100644
--- a/src/imagination/vulkan/pvr_job_transfer.c
+++ b/src/imagination/vulkan/pvr_job_transfer.c
@@ -325,7 +325,8 @@ pvr_pbe_src_format_normal(VkFormat src_format,
                           bool dont_force_pbe,
                           enum pvr_transfer_pbe_pixel_src *src_format_out)
 {
-   bool dst_signed = vk_format_is_sint(dst_format);
+   bool dst_signed = vk_format_is_sint(dst_format) ||
+                     vk_format_is_snorm(dst_format);
 
    if (vk_format_is_int(dst_format)) {
       uint32_t red_width;