From: Philipp Hortmann Date: Fri, 20 Jan 2023 20:18:26 +0000 (+0100) Subject: staging: rtl8192e: Remove u4RegValue which is always zero X-Git-Tag: v6.6.7~3436^2~103 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9fb469870f7d194488a9c76d8eb49500bbdaee86;p=platform%2Fkernel%2Flinux-starfive.git staging: rtl8192e: Remove u4RegValue which is always zero As the array antenna_tx_pwr_diff is always zero, u4RegValue is always set to zero. Replace u4RegValue to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann Link: https://lore.kernel.org/r/2aa104c0f7a5cede7eea289fe92390295592b0e9.1674244819.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c index c969c40..d56c58e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -586,7 +586,6 @@ void rtl92e_set_tx_power(struct net_device *dev, u8 channel) { struct r8192_priv *priv = rtllib_priv(dev); u8 powerlevel = 0, powerlevelOFDM24G = 0; - u32 u4RegValue; if (priv->epromtype == EEPROM_93C46) { powerlevel = priv->tx_pwr_level_cck[channel - 1]; @@ -603,13 +602,8 @@ void rtl92e_set_tx_power(struct net_device *dev, u8 channel) priv->antenna_tx_pwr_diff[1] = 0; priv->antenna_tx_pwr_diff[0] = 0; - u4RegValue = priv->antenna_tx_pwr_diff[2] << 8 | - priv->antenna_tx_pwr_diff[1] << 4 | - priv->antenna_tx_pwr_diff[0]; - rtl92e_set_bb_reg(dev, rFPGA0_TxGainStage, - (bXBTxAGC|bXCTxAGC|bXDTxAGC), - u4RegValue); + (bXBTxAGC | bXCTxAGC | bXDTxAGC), 0); } } switch (priv->rf_chip) {