From: Christopher Michael <cp.michael@samsung.com>
Date: Tue, 12 Mar 2019 14:15:00 +0000 (-0400)
Subject: evas_device: Fix dereferencing null pointer
X-Git-Tag: submit/tizen/20190402.051338~208
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9faf27ceaf6bd53af6343ab676350b96b3151353;p=platform%2Fupstream%2Fefl.git

evas_device: Fix dereferencing null pointer

Coverity reports that 'pos' could be null here and we are potentially
dereferencing a NULL pointer, so lets add a check for 'pos' here
before trying to use it.

Fixes Coverity CID1399091

@fix

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8313
---

diff --git a/src/lib/evas/canvas/evas_device.c b/src/lib/evas/canvas/evas_device.c
index 2e5e141b76..c07748ea44 100644
--- a/src/lib/evas/canvas/evas_device.c
+++ b/src/lib/evas/canvas/evas_device.c
@@ -538,7 +538,9 @@ _evas_canvas_efl_canvas_scene_pointer_position_get(const Eo *eo_e, Evas_Public_D
    Eina_Iterator *it;
    Eo *child;
 
-   if (pos) *pos = EINA_POSITION2D(0, 0);
+   if (!pos) return EINA_FALSE;
+
+   *pos = EINA_POSITION2D(0, 0);
    if (!e->default_seat) return EINA_FALSE;
    if (!seat)
      {
@@ -553,6 +555,7 @@ _evas_canvas_efl_canvas_scene_pointer_position_get(const Eo *eo_e, Evas_Public_D
        break;
    if (child)
      *pos = efl_input_pointer_position_get(child);
+
    eina_iterator_free(it);
    return !!child;
 }