From: Linus Walleij Date: Mon, 21 Dec 2015 10:48:48 +0000 (+0100) Subject: gpio: tz1090: Be sure to clamp return value X-Git-Tag: v4.14-rc1~3997^2~155 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9fa90796244aa6043d59c8e127845ff9e3b01485;p=platform%2Fkernel%2Flinux-rpi.git gpio: tz1090: Be sure to clamp return value As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Acked-by: James Hogan Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c index 79ef6e1..a4a8225 100644 --- a/drivers/gpio/gpio-tz1090.c +++ b/drivers/gpio/gpio-tz1090.c @@ -214,7 +214,7 @@ static int tz1090_gpio_get(struct gpio_chip *chip, unsigned int offset) { struct tz1090_gpio_bank *bank = to_bank(chip); - return tz1090_gpio_read_bit(bank, REG_GPIO_DIN, offset); + return !!tz1090_gpio_read_bit(bank, REG_GPIO_DIN, offset); } /*