From: Vladimir Oltean <olteanv@gmail.com>
Date: Thu, 27 Jun 2019 21:46:37 +0000 (+0300)
Subject: net: dsa: sja1105: Mark in-band AN modes not supported for PHYLINK
X-Git-Tag: v5.4-rc1~616^2~116^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9f971573d96fc55efe9d48ff2ca160c9b95fbe37;p=platform%2Fkernel%2Flinux-rpi.git

net: dsa: sja1105: Mark in-band AN modes not supported for PHYLINK

We need a better way to signal this, perhaps in phylink_validate, but
for now just print this error message as guidance for other people
looking at this driver's code while trying to rework PHYLINK.

Cc: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index b366b8e..32bf3a7 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -806,6 +806,11 @@ static void sja1105_mac_config(struct dsa_switch *ds, int port,
 	if (sja1105_phy_mode_mismatch(priv, port, state->interface))
 		return;
 
+	if (link_an_mode == MLO_AN_INBAND) {
+		dev_err(ds->dev, "In-band AN not supported!\n");
+		return;
+	}
+
 	sja1105_adjust_port_config(priv, port, state->speed);
 }