From: Benjamin Segovia <segovia.benjamin@gmail.com>
Date: Fri, 11 May 2012 18:03:15 +0000 (+0000)
Subject: Added load immediates of bytes and shorts
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9f6d2326e52c2be967dc46d5b36426f857802eb9;p=contrib%2Fbeignet.git

Added load immediates of bytes and shorts
---

diff --git a/backend/src/backend/gen_context.cpp b/backend/src/backend/gen_context.cpp
index 54080c7..f36c2aa 100644
--- a/backend/src/backend/gen_context.cpp
+++ b/backend/src/backend/gen_context.cpp
@@ -134,7 +134,7 @@ namespace gbe
   if (this->isScalarReg(reg) == true) { \
     RA.insert(std::make_pair(reg, GenReg::SIMD1(nr, subnr))); \
     grfOffset += typeSize; \
-  } if (simdWidth == 16) { \
+  } else if (simdWidth == 16) { \
     RA.insert(std::make_pair(reg, GenReg::SIMD16(nr, subnr))); \
     grfOffset += simdWidth * typeSize; \
   } else if (simdWidth == 8) {\
@@ -477,26 +477,18 @@ namespace gbe
 
     GBE_ASSERT(dstFamily != FAMILY_QWORD && srcFamily != FAMILY_QWORD);
 
-    // We need two steps here to make the conversion
+    // We need two instructions to make the conversion
     if (dstFamily != FAMILY_DWORD && srcFamily == FAMILY_DWORD) {
       GenReg unpacked;
-      if (dstFamily == FAMILY_WORD)
-        unpacked = GenReg(GEN_GENERAL_REGISTER_FILE,
-                          112,
-                          0,
-                          dstType == TYPE_U16 ? GEN_TYPE_UW : GEN_TYPE_W,
-                          GEN_VERTICAL_STRIDE_16,
-                          GEN_WIDTH_8,
-                          GEN_HORIZONTAL_STRIDE_2);
-      else
-        GBE_ASSERT(dstFamily == FAMILY_BYTE);
-        unpacked = GenReg(GEN_GENERAL_REGISTER_FILE,
-                          112,
-                          0,
-                          dstType == TYPE_U8 ? GEN_TYPE_UB : GEN_TYPE_B,
-                          GEN_VERTICAL_STRIDE_32,
-                          GEN_WIDTH_8,
-                          GEN_HORIZONTAL_STRIDE_4);
+      if (dstFamily == FAMILY_WORD) {
+        const uint32_t type = TYPE_U16 ? GEN_TYPE_UW : GEN_TYPE_W;
+        unpacked = GenReg::unpacked_uw(112, 0);
+        unpacked = GenReg::retype(unpacked, type);
+      } else {
+        const uint32_t type = TYPE_U8 ? GEN_TYPE_UB : GEN_TYPE_B;
+        unpacked = GenReg::unpacked_ub(112, 0);
+        unpacked = GenReg::retype(unpacked, type);
+      }
       p->MOV(unpacked, src);
       p->MOV(dst, unpacked);
     } else
@@ -540,6 +532,10 @@ namespace gbe
     switch (type) {
       case TYPE_U32: p->MOV(dst, GenReg::immud(imm.data.u32)); break;
       case TYPE_S32: p->MOV(dst, GenReg::immd(imm.data.s32)); break;
+      case TYPE_U16: p->MOV(dst, GenReg::immuw(imm.data.u16)); break;
+      case TYPE_S16: p->MOV(dst, GenReg::immw(imm.data.s16)); break;
+      case TYPE_U8:  p->MOV(dst, GenReg::immuw(imm.data.u8)); break;
+      case TYPE_S8:  p->MOV(dst, GenReg::immw(imm.data.s8)); break;
       case TYPE_FLOAT: p->MOV(dst, GenReg::immf(imm.data.f32)); break;
       default: NOT_SUPPORTED;
     }
@@ -626,9 +622,9 @@ namespace gbe
 
     // Repack bytes or words using a converting mov instruction
     if (elemSize == GEN_BYTE_SCATTER_WORD)
-      p->MOV(GenReg::retype(value, GEN_TYPE_UW), GenReg::retype(dst, GEN_TYPE_UD));
+      p->MOV(GenReg::retype(value, GEN_TYPE_UW), GenReg::unpacked_uw(dst.nr, 0));
     else if (elemSize == GEN_BYTE_SCATTER_BYTE)
-      p->MOV(GenReg::retype(value, GEN_TYPE_UB), GenReg::retype(dst, GEN_TYPE_UD));
+      p->MOV(GenReg::retype(value, GEN_TYPE_UB), GenReg::unpacked_ub(dst.nr, 0));
   }
 
   void GenContext::emitLoadInstruction(const ir::LoadInstruction &insn) {
diff --git a/backend/src/backend/gen_eu.hpp b/backend/src/backend/gen_eu.hpp
index b61c6eb..968a6ab 100644
--- a/backend/src/backend/gen_eu.hpp
+++ b/backend/src/backend/gen_eu.hpp
@@ -232,6 +232,26 @@ namespace gbe
       return suboffset(retype(vec1(file, nr, 0), GEN_TYPE_UB), subnr);
     }
 
+    static INLINE GenReg unpacked_uw(uint32_t nr, uint32_t subnr) {
+        return GenReg(GEN_GENERAL_REGISTER_FILE,
+                      nr,
+                      subnr,
+                      GEN_TYPE_UW,
+                      GEN_VERTICAL_STRIDE_16,
+                      GEN_WIDTH_8,
+                      GEN_HORIZONTAL_STRIDE_2);
+    }
+
+    static INLINE GenReg unpacked_ub(uint32_t nr, uint32_t subnr) {
+      return GenReg(GEN_GENERAL_REGISTER_FILE,
+                    nr,
+                    subnr,
+                    GEN_TYPE_UB,
+                    GEN_VERTICAL_STRIDE_32,
+                    GEN_WIDTH_8,
+                    GEN_HORIZONTAL_STRIDE_4);
+    }
+
     static INLINE GenReg imm(uint32_t type) {
       return GenReg(GEN_IMMEDIATE_VALUE,
                     0,
@@ -266,7 +286,7 @@ namespace gbe
       return immediate;
     }
 
-    static INLINE GenReg immw(short w) {
+    static INLINE GenReg immw(int16_t w) {
       GenReg immediate = imm(GEN_TYPE_W);
       immediate.dw1.d = w | (w << 16);
       return immediate;