From: Karol Furmaniak Date: Tue, 3 Feb 2015 13:56:38 +0000 (+0100) Subject: Navigate forward button is disabled. X-Git-Tag: submit/tizen/20201118.160233~1324 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9f188baeb49984a4211d2402e89d0ce5595b579f;p=platform%2Fframework%2Fweb%2Fchromium-efl.git Navigate forward button is disabled. [Problem]: After navigate with "back" button forward button is still disabled. [Solution]: Invoking BackForwardListChangedCallback depends on back/forward list count difference. Unnecessary condition was removed. Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10900 Reviewed by: Jaesik Chang, Piotr Grad, arno renevier Change-Id: I080925a6ee8b42345fd5bd8df8d39d45ec1a489f Signed-off-by: Karol Furmaniak --- diff --git a/tizen_src/impl/web_contents_delegate_efl.cc b/tizen_src/impl/web_contents_delegate_efl.cc index 88b8ea8..cb31224 100644 --- a/tizen_src/impl/web_contents_delegate_efl.cc +++ b/tizen_src/impl/web_contents_delegate_efl.cc @@ -72,7 +72,6 @@ WebContentsDelegateEfl::WebContentsDelegateEfl(EWebView* view) , web_contents_(view->web_contents()) , document_created_(false) , dialog_manager_(NULL) - , forward_backward_list_count_(0) , WebContentsObserver(&view->web_contents()) , weak_ptr_factory_(this) { #ifdef TIZEN_AUTOFILL_SUPPORT @@ -547,11 +546,7 @@ void WebContentsDelegateEfl::OnPrintedMetafileReceived(const DidPrintPagesParams } void WebContentsDelegateEfl::NavigationEntryCommitted(const LoadCommittedDetails& load_details) { - int forward_backward_list_count = web_contents_.GetController().GetEntryCount(); - if (forward_backward_list_count != forward_backward_list_count_) { - web_view_->InvokeBackForwardListChangedCallback(); - forward_backward_list_count_ = forward_backward_list_count; - } + web_view_->InvokeBackForwardListChangedCallback(); } void WebContentsDelegateEfl::RenderProcessGone(base::TerminationStatus status) { diff --git a/tizen_src/impl/web_contents_delegate_efl.h b/tizen_src/impl/web_contents_delegate_efl.h index 77d1b2f..c8c8919 100644 --- a/tizen_src/impl/web_contents_delegate_efl.h +++ b/tizen_src/impl/web_contents_delegate_efl.h @@ -202,7 +202,6 @@ class WebContentsDelegateEfl scoped_ptr pending_content_security_policy_; bool document_created_; JavaScriptDialogManagerEfl* dialog_manager_; - int forward_backward_list_count_; scoped_ptr favicon_downloader_; base::WeakPtrFactory weak_ptr_factory_; scoped_ptr<_Ewk_Certificate_Policy_Decision> certificate_policy_decision_;