From: Wei Yongjun Date: Mon, 8 Oct 2012 21:32:49 +0000 (-0700) Subject: OMAPDSS: fix return value check in create_dss_pdev() X-Git-Tag: upstream/snapshot3+hdmi~6471^2~4^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9ee677231bbc6a9e6ec9057d33d81eb248742b0a;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git OMAPDSS: fix return value check in create_dss_pdev() In case of error, the function omap_device_alloc() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Signed-off-by: Tony Lindgren --- diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index 7012068..a51ece4 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -221,7 +221,7 @@ static struct platform_device *create_dss_pdev(const char *pdev_name, ohs[0] = oh; od = omap_device_alloc(pdev, ohs, 1, NULL, 0); - if (!od) { + if (IS_ERR(od)) { pr_err("Could not alloc omap_device for %s\n", pdev_name); r = -ENOMEM; goto err;