From: Nicholas Clark <nick@ccl4.org>
Date: Sun, 13 Mar 2011 21:30:55 +0000 (+0000)
Subject: In test.pl, avoid using a closure to capture warnings.
X-Git-Tag: accepted/trunk/20130322.191538~4967
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9eb41b690e9c66416ca5e28fe9acb0f2595cbd3f;p=platform%2Fupstream%2Fperl.git

In test.pl, avoid using a closure to capture warnings.

In the general case a closure is the "right" way to do "it". However, closures,
unlike local and regular subroutines, have some complexity at compile time,
which means that using closures in test.pl runs the risk of closure bugs
causing spurious hard to diagnose collateral damage to other tests. local is
already in use, and "has" to work for capturing warnings, as $SIG{__WARN__} is
localised already.
---

diff --git a/t/test.pl b/t/test.pl
index d83f69b..d9b9432 100644
--- a/t/test.pl
+++ b/t/test.pl
@@ -1097,13 +1097,18 @@ WHOA
     _ok( !$diag, _where(), $name );
 }
 
+# Purposefully avoiding a closure.
+sub __capture {
+    push @::__capture, join "", @_;
+}
+    
 sub capture_warnings {
     my $code = shift;
 
-    my @w;
-    local $SIG {__WARN__} = sub {push @w, join "", @_};
+    local @::__capture;
+    local $SIG {__WARN__} = \&__capture;
     &$code;
-    return @w;
+    return @::__capture;
 }
 
 # This will generate a variable number of tests.